Add Null Coalesce Operator #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @carusogabriel I can write the sniff for https://github.com/slevomat/coding-standard, would it be ok? |
| @kukulich Perfect. I'm not good at sniffers, so I appreciate your help 😄 |
| Fine, I may write it in the evening if my children and wife allow :) |
| Ready for test: slevomat/coding-standard@476b0da |
carusogabriel commented Jan 31, 2018
| | ||
| $bar = isset($bar['baz']) ? $bar['baz'] : 'baz'; | ||
| | ||
| if (isset($foo)) { |
There was a problem hiding this comment.
@kukulich This case is already covered? I guess tests are failing here
There was a problem hiding this comment.
Nope, it's not. It's a lot more complicated than simple ternary operator.
Ocramius reviewed Feb 5, 2018
composer.json Outdated
| "squizlabs/php_codesniffer": "^3.2", | ||
| "dealerdirect/phpcodesniffer-composer-installer": "^0.4.2", | ||
| "slevomat/coding-standard": "^4.3.0" | ||
| "slevomat/coding-standard": "dev-master" |
There was a problem hiding this comment.
Same here: we need a stable release and then we can merge/release as well
carusogabriel changed the title 
alcaeus approved these changes Feb 6, 2018
| Manually merged in 2636a26 Thanks @kukulich and @carusogabriel! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Some to help starts with: https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/2.10/src/Fixer/Operator/TernaryToNullCoalescingFixer.php
Something to also be considering:
Already proposed and voted in #9 (comment)