Adopt PSR-12 for imports statements separation #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
[PSR-12](https://www.php-fig.org/psr/psr-12) is an extension of the PSR-2 set of rules that aims to standardize the code style. As per PSR-12, under the [item 3](https://www.php-fig.org/psr/psr-12/#3-declare-statements-namespace-and-import-statements): The header of a PHP file may consist of a number of different blocks. If present, each of the blocks below MUST be separated by a single blank line, and MUST NOT contain a blank line. Each block MUST be in the order listed below, although blocks that are not relevant may be omitted. For context on why this was voted in the past, see #9.
carusogabriel force-pushed the feature/psr-12-important-statements-separation branch from e6da438 to 1ede95a Compare 
| Most important question: does PHPStorm fold all the uses or now I'll have a folded use section for each group? |
| @malarzm Yes, it does 🎉
I'm gonna assume since 2019.3, as per this article:
|
malarzm approved these changes Mar 20, 2020
beberlei approved these changes Mar 20, 2020
greg0ire approved these changes Mar 20, 2020
alcaeus approved these changes Mar 20, 2020
ostrolucky approved these changes Mar 20, 2020
morozov approved these changes Mar 20, 2020
SenseException approved these changes Mar 20, 2020
| Thanks @carusogabriel ! |
| Thanks @carusogabriel ! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PSR-12 is an extension of the PSR-2 set of rules
that aims to standardize the code style.
As per PSR-12, under the item 3:
For context on why this was voted in the past, see #9.