add support for bundle namespace alias #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2014
| cleaned up naming |
fabpot added a commit to symfony/symfony that referenced this pull request Aug 8, 2014
…pace aliases (dbu) This PR was merged into the 2.6-dev branch. Discussion ---------- provide a compiler pass for doctrine to register namespace aliases | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#4069 I realized that the compiler pass only allows bundles to register folders to load entities / documents but not namespace alias to make things like `CmfRoutingBundle:Route` work. This is an attempt to provide a separate compiler pass for this. Maybe we should instead provide a new combined compiler pass and have users switch to the new pass if available. * [x] [Doctrine ORM](doctrine/DoctrineBundle#316) * [x] [DoctrinePHPCRBundle](doctrine/DoctrinePHPCRBundle#158) * [ ] Doctrine CouchDB * [ ] Doctrine MongoDB Commits ------- 9a62ab3 provide a compiler pass for doctrine to register namespace aliases and not only mapping drivers
dbu added a commit that referenced this pull request Aug 8, 2014
add support for bundle namespace alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a backwards compatible change for adding support for namespace alias as with auto-mapped documents in the default Document folder.
The alias only work with symfony/symfony#10853 , are ignored otherwise. Lets still wait for the symfony core PR to be merged before merging this.