Skip to content

Conversation

@kokspflanze
Copy link
Contributor

changed getMock to getMockBuilder for PHPUnit 5.4+
changed setExpectedException to expectException it is already deprecated

changed arraysyntax in unittests
updated composer.json to min PHPUnit 5.5.0

@michalbundyra
Copy link
Member

@kokspflanze getMock is deprecated but you can use createMock instead in PHPUnit 5. It is shorter than ...->getMockBuilder(...)->getMock().

@gianarb
Copy link
Contributor

gianarb commented Oct 3, 2016

Thanks @kokspflanze

@Ocramius do we have a sort of standard? will we use createMock or getMockBuilder?

👍 getMockBuilder
💯 createMock

Reaction please! @webimpress :)

@michalbundyra
Copy link
Member

For me both are fine. Personally I'd prefer shorter version when possible. I would also go with ::class notation, but it could be done later on in separate PR. It will be much nicer!

@kokspflanze
Copy link
Contributor Author

about the ::class i will create a new PR after my vacation

update composer.json && composer.lock
changed array syntax in tests to `[]`
update composer.json && composer.lock
#	composer.lock
# Conflicts: #	composer.lock
@gianarb
Copy link
Contributor

gianarb commented Oct 13, 2016

Thanks a lot @kokspflanze

@gianarb gianarb merged commit 4d0412e into doctrine:master Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants