Skip to content

Conversation

sy-records
Copy link
Member

Summary

There are some issues with clicking on awesome and changelog. https://preview.docsifyjs.org/#/awesome

The solution is to remove the p tag from the top level <li><p><a></a></p></li>.

Related issue, if any:

What kind of change does this PR introduce?

Bugfix

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

Yes

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
Copy link

vercel bot commented Jul 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2025 11:27am
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the root cause may be the styling since the display:none apply to all the non a elements.
As a single line in _sidebar.md , which does't as a group but a link, we need reconsider how to structure the sidebar and refine the css selector.

&.collapse { > :not(a) { display: none; } }

cc @jhildenbiddle

@sy-records
Copy link
Member Author

- [UI Kit](ui-kit.md) - [Awesome docsify](awesome.md) - [Changelog](changelog.md) <ul> <li><a href="#/ui-kit" title="UI Kit" class="page-link">UI Kit</a></li> <li><a href="#/awesome" title="Awesome docsify" class="page-link">Awesome docsify</a></li> <li><a href="#/changelog" title="Changelog" class="page-link">Changelog</a></li> </ul> 
- Guide - [UI Kit](ui-kit.md) - [Awesome docsify](awesome.md) - [Changelog](changelog.md) <ul> <li class="group"><p class="group-title">Guide</p> <ul> <li><a href="#/ui-kit" title="UI Kit" class="page-link">UI Kit</a></li> </ul> </li> <li><p><a href="#/awesome" title="Awesome docsify" class="page-link">Awesome docsify</a></p></li> <li><p><a href="#/changelog" title="Changelog" class="page-link">Changelog</a></p></li> </ul> 
@sy-records sy-records changed the title fix: unwrap <p> tags around <a> in top-level sidebar items docs: update sidebar link formatting Jul 28, 2025
@Koooooo-7 Koooooo-7 merged commit 5a49729 into docsifyjs:develop Jul 28, 2025
8 checks passed
@sy-records sy-records deleted the fix/ptag branch July 29, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants