Skip to content

Conversation

@vercel
Copy link

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 9:45am
@paulhibbitts
Copy link
Collaborator

paulhibbitts commented Jul 23, 2025

Thanks very much @sy-records , I've now updated the earlier Docsify v5 Font Awesome plugin test site with the PR Preview and you can see things are looking good!

Using updated PR Preview (no additional CSS):
https://paulhibbitts.github.io/docsify-v5-font-awesome-test/#/font-awesome

Earlier test CSS you provided:
https://paulhibbitts.github.io/docsify-v5-font-awesome-test/#/font-awesome-fix-1

So from my perspective everything looks good so no changes now required in plugin, correct? cc @erickjx

@sy-records
Copy link
Member Author

yep

Copy link
Collaborator

@paulhibbitts paulhibbitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my test results everything looks good to me!

@sy-records sy-records merged commit 6e45024 into docsifyjs:develop Jul 24, 2025
8 checks passed
@sy-records sy-records deleted the fix/css branch July 24, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants