Skip to content

feat: Native emoji w/ image-based fallbacks and improved parsing #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhildenbiddle merged 39 commits into from
Mar 6, 2022
Merged

feat: Native emoji w/ image-based fallbacks and improved parsing #1746

Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
936d566
Render native emoji with image fallback
jhildenbiddle Feb 4, 2022
e7d627a
Deprecate emoji plugin
jhildenbiddle Feb 4, 2022
db1e94e
Add emoji tests
jhildenbiddle Feb 4, 2022
1fa45e5
Remove console.log statement
jhildenbiddle Feb 4, 2022
8252f3a
Fix emoji image alt attribute
jhildenbiddle Feb 4, 2022
b8c227f
Set nativeEmoji to false by default (non-breaking)
jhildenbiddle Feb 4, 2022
d03aa4f
Fix parsing emoji in HTML comments and script tags
jhildenbiddle Feb 4, 2022
39d5204
Add nativeEmoji and update noEmoji details
jhildenbiddle Feb 4, 2022
baf8044
Add Emoji plugin deprecation notice
jhildenbiddle Feb 5, 2022
39bf522
Fix ESLint issues
jhildenbiddle Feb 5, 2022
e1e8d22
Create build:emoji task
jhildenbiddle Feb 5, 2022
8c10b5f
Fix rendering of GitHub emoji without unicode
jhildenbiddle Feb 5, 2022
208049b
Adjust and match size of native and image emoji
jhildenbiddle Feb 5, 2022
b7a3b67
Update emoji test snapshot
jhildenbiddle Feb 5, 2022
260992c
Update docs test snapshot
jhildenbiddle Feb 5, 2022
2079441
Merge branch 'develop' into feat-native-emoji
Koooooo-7 Feb 5, 2022
8b587b8
Fix ci/codesandbox error
jhildenbiddle Feb 5, 2022
53d5fb5
Update native emoji font-stack
jhildenbiddle Feb 6, 2022
e9d5722
Fix rendering of native multi-character emoji
jhildenbiddle Feb 6, 2022
7c15fd7
Kick GitHub Workflow
jhildenbiddle Feb 6, 2022
05c7974
Merge branch 'develop' into feat-native-emoji
jhildenbiddle Mar 4, 2022
7ba8513
Replace rollup’s uglify plugin with terser
jhildenbiddle Mar 4, 2022
d52b476
Switch “npm ci” instead of “npm i” for stability
jhildenbiddle Mar 4, 2022
3f2dd46
Change emoji data from default to named export
jhildenbiddle Mar 4, 2022
e06fed4
Revert "Replace rollup’s uglify plugin with terser"
jhildenbiddle Mar 4, 2022
77cb0cd
Revert "Switch “npm ci” instead of “npm i” for stability"
jhildenbiddle Mar 4, 2022
98185ca
Revert "Change emoji data from default to named export"
jhildenbiddle Mar 4, 2022
bec3e0d
Specify codesandbox template and node version
jhildenbiddle Mar 4, 2022
16aec44
Update codesandbox config
jhildenbiddle Mar 4, 2022
27d4952
Revert "Revert "Replace rollup’s uglify plugin with terser""
jhildenbiddle Mar 4, 2022
4208c82
Revert "Revert "Revert "Replace rollup’s uglify plugin with terser"""
jhildenbiddle Mar 4, 2022
5120dd2
Update codesandbox config
jhildenbiddle Mar 4, 2022
8cdf27e
Revert "Update codesandbox config"
jhildenbiddle Mar 4, 2022
9d522d5
Fix codesandbox uglify error
jhildenbiddle Mar 4, 2022
ddf7ad2
Emoji docs tweaks
jhildenbiddle Mar 5, 2022
da6480d
Restore and update emoji plugin code
jhildenbiddle Mar 5, 2022
4a1d87e
Restore and update emoji plugin docs
jhildenbiddle Mar 5, 2022
d9fc279
Prettier updates
jhildenbiddle Mar 5, 2022
af45845
Match lowercase shortcodes only
jhildenbiddle Mar 5, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update emoji test snapshot
  • Loading branch information
@jhildenbiddle
jhildenbiddle committed Feb 5, 2022
commit b7a3b6737e2fa82b814c1fe84104eacb04777e62
2 changes: 1 addition & 1 deletion test/integration/__snapshots__/emoji.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ exports[`Emoji Ignores emoji shorthand codes in comments 1`] = `"<p>Text <!-- :f

exports[`Emoji Ignores unmatched emoji shorthand codes 1`] = `"<p>hh:mm</p><p>hh:mm:ss</p><p>Namespace::SubNameSpace</p><p>Namespace::SubNameSpace::Class</p><p>2014-12-29T16:11:20+00:00</p>"`;

exports[`Emoji Renders GitHub emoji images (nativeEmoji:false) 1`] = `"<p><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"></p><p><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"></p><p><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"> <img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"></p><p><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"></p><p><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"> <img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"> <img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"></p><p>text<img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\"></p><p><img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\">text</p><p>text<img class=\\"emoji\\" src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png\\" alt=\\"smile\\">text</p>"`;
exports[`Emoji Renders GitHub emoji images (nativeEmoji:false) 1`] = `"<p><img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png?v8.png\\" alt=\\"smile\\" class=\\"emoji\\" loading=\\"lazy\\"></p><p><img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png?v8.png\\" alt=\\"smile\\" class=\\"emoji\\" loading=\\"lazy\\"><img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png?v8.png\\" alt=\\"smile\\" class=\\"emoji\\" loading=\\"lazy\\"></p><p><img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png?v8.png\\" alt=\\"smile\\" class=\\"emoji\\" loading=\\"lazy\\"> <img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png?v8.png\\" alt=\\"smile\\" class=\\"emoji\\" loading=\\"lazy\\"></p><p><img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png?v8.png\\" alt=\\"smile\\" class=\\"emoji\\" loading=\\"lazy\\"><img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png?v8.png\\" alt=\\"smile\\" class=\\"emoji\\" loading=\\"lazy\\"><img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png?v8.png\\" alt=\\"smile\\" class=\\"emoji\\" loading=\\"lazy\\"></p><p><img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png?v8.png\\" alt=\\"smile\\" class=\\"emoji\\" loading=\\"lazy\\"> <img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png?v8.png\\" alt=\\"smile\\" class=\\"emoji\\" loading=\\"lazy\\"> <img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png?v8.png\\" alt=\\"smile\\" class=\\"emoji\\" loading=\\"lazy\\"></p><p>text<img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png?v8.png\\" alt=\\"smile\\" class=\\"emoji\\" loading=\\"lazy\\"></p><p><img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png?v8.png\\" alt=\\"smile\\" class=\\"emoji\\" loading=\\"lazy\\">text</p><p>text<img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f604.png?v8.png\\" alt=\\"smile\\" class=\\"emoji\\" loading=\\"lazy\\">text</p>"`;

exports[`Emoji Renders native emoji characters (nativeEmoji:true) 1`] = `"<p><span class=\\"emoji\\">😄︎</span></p><p><span class=\\"emoji\\">😄︎</span><span class=\\"emoji\\">😄︎</span></p><p><span class=\\"emoji\\">😄︎</span> <span class=\\"emoji\\">😄︎</span></p><p><span class=\\"emoji\\">😄︎</span><span class=\\"emoji\\">😄︎</span><span class=\\"emoji\\">😄︎</span></p><p><span class=\\"emoji\\">😄︎</span> <span class=\\"emoji\\">😄︎</span> <span class=\\"emoji\\">😄︎</span></p><p>text<span class=\\"emoji\\">😄︎</span></p><p><span class=\\"emoji\\">😄︎</span>text</p><p>text<span class=\\"emoji\\">😄︎</span>text</p>"`;