Skip to content

fix: Add escapeHtml for search #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2021
Merged

fix: Add escapeHtml for search #1551

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
958ca9b
fix: Add escapeHtml for search
sy-records Apr 1, 2021
3b2cce1
Merge branch 'develop' into fix-1549
anikethsaha Apr 10, 2021
8c8ef8e
Merge branch 'develop' into fix-1549
sy-records Apr 12, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/plugins/search/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export function search(query) {
keywords.forEach(keyword => {
// From https://github.com/sindresorhus/escape-string-regexp
const regEx = new RegExp(
ignoreDiacriticalMarks(keyword).replace(
escapeHtml(ignoreDiacriticalMarks(keyword)).replace(
/[|\\{}()[\]^$+*?.]/g,
'\\$&'
),
Expand All @@ -187,10 +187,10 @@ export function search(query) {
let indexTitle = -1;
let indexContent = -1;
handlePostTitle = postTitle
? ignoreDiacriticalMarks(postTitle)
? escapeHtml(ignoreDiacriticalMarks(postTitle))
: postTitle;
handlePostContent = postContent
? ignoreDiacriticalMarks(postContent)
? escapeHtml(ignoreDiacriticalMarks(postContent))
: postContent;

indexTitle = postTitle ? handlePostTitle.search(regEx) : -1;
Expand Down