Skip to content

fix: duplicate search content when /README or / exists in the sidebar #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 28, 2020
Merged

fix: duplicate search content when /README or / exists in the sidebar #1403

Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4b88592
fix: duplicate search content when `/readme` or `/` exists in the sid…
sy-records Oct 20, 2020
9bc7f3a
Merge branch 'develop' into fix-search
sy-records Nov 6, 2020
19060ae
Merge branch 'develop' into fix-search
sy-records Nov 9, 2020
8dc35e8
Merge branch 'develop' into fix-search
sy-records Nov 20, 2020
f494147
Update
sy-records Nov 21, 2020
93ea8a0
add test
sy-records Nov 21, 2020
caff169
Reset local storage before each e2e test
jhildenbiddle Nov 21, 2020
d564580
Reset Playwright context instead of page
jhildenbiddle Nov 21, 2020
a25d8db
Update playwright dependencies
jhildenbiddle Nov 21, 2020
8b462ca
Merge branch 'develop' into fix-search
sy-records Nov 22, 2020
d6800c3
Merge branch 'develop' into fix-search
sy-records Nov 24, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/plugins/search/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,13 @@ export function init(config, vm) {
namespaceSuffix = matches[0];
}
}
paths.unshift(namespaceSuffix + '/');
} else {
if (
paths.indexOf(namespaceSuffix + '/') === -1 &&
paths.indexOf(namespaceSuffix + '/README') === -1
) {
paths.unshift(namespaceSuffix + '/');
}
} else if (paths.indexOf('/') === -1 && paths.indexOf('/README') === -1) {
paths.unshift('/');
}

Expand Down