fix: gitignore was ignoring folders in src… #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… or file fuzzy finder were not working, etc
| This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/6k0o326rq |
| This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e664a34:
|
trusktr commented Jul 16, 2020
| | ||
| --- | ||
| | ||
| * [ ] DO NOT include files inside `lib` directory. |
There was a problem hiding this comment.
No reason to keep this, it is listed in gitignore.
trusktr changed the title trusktr requested review from anikethsaha, jhildenbiddle, jthegedus, Koooooo-7, sy-records and a team 
sy-records approved these changes Jul 16, 2020
Koooooo-7 approved these changes Jul 16, 2020
anikethsaha approved these changes Jul 16, 2020
This was referenced Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…so VS Code search results or file fuzzy finder were not working, etc
Summary
.gitignorewas ignoring stuff in thesrcfolder. VS Code respects.gitignore, so this caused VS Code not to show me search results in files inside of thesrc/themes/folder, and to not be able to open those files using the file palette (fuzzy finder).What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
libdirectory. (/libis in gitignore, why do we need this check box?)