Skip to content

fix 1098 #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2020
Merged

fix 1098 #1175

merged 3 commits into from
May 22, 2020

Conversation

@sy-records
Copy link
Member

@sy-records sy-records commented May 13, 2020

Summary

fix #1098

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

  • DO NOT include files inside lib directory.
@sy-records sy-records requested a review from anikethsaha May 13, 2020 07:44
anikethsaha
anikethsaha requested changes May 13, 2020
View reviewed changes
@anikethsaha anikethsaha requested review from Koooooo-7 and trusktr May 13, 2020 07:58
@trusktr trusktr mentioned this pull request May 14, 2020
Closed
19 tasks
@anikethsaha
Copy link
Member

anikethsaha commented May 18, 2020

cc @trusktr @Koooooo-7
@anikethsaha anikethsaha added the semver-patch This needs a patch release label May 18, 2020
Koooooo-7
Koooooo-7 approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List those possible cases seems not elegent. 😅
@anikethsaha anikethsaha reopened this May 20, 2020
@anikethsaha anikethsaha merged commit e9dd2de into develop May 22, 2020
@anikethsaha anikethsaha deleted the fix-1098 branch May 22, 2020 09:55
@sy-records sy-records linked an issue May 25, 2020 that may be closed by this pull request
Cannot jump to the content of the search by clicking the results #1090
Closed
@sy-records sy-records mentioned this pull request May 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch This needs a patch release

6 participants

@sy-records @anikethsaha @trusktr @stepozer @Koooooo-7