feat: add support for floats to docker logs params since / until sinc… #3031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ArchiMoebius force-pushed the feature_floating_docker_logs branch from 3fa85c7 to 7c1e4cc Compare 
…e the docker engine supports it Signed-off-by: Archi Moebius <poerhiz@gmail.com>
ArchiMoebius force-pushed the feature_floating_docker_logs branch from 7c1e4cc to c92c03d Compare 
milas suggested changes Aug 17, 2022
Contributor
milas left a comment
milas left a comment There was a problem hiding this comment.
Thanks for the PR!
Looks good -- just a couple tiny suggestions to update the error messages for unsupported types.
milas suggested changes Aug 17, 2022
Contributor
milas left a comment
milas left a comment There was a problem hiding this comment.
Ah another thing - "in nanoseconds" is misleading
Co-authored-by: Milas Bowman <milasb@gmail.com> Signed-off-by: Rhiza <6900588+ArchiMoebius@users.noreply.github.com>
Co-authored-by: Milas Bowman <milasb@gmail.com> Signed-off-by: Rhiza <6900588+ArchiMoebius@users.noreply.github.com>
Co-authored-by: Milas Bowman <milasb@gmail.com> Signed-off-by: Rhiza <6900588+ArchiMoebius@users.noreply.github.com>
Co-authored-by: Milas Bowman <milasb@gmail.com> Signed-off-by: Rhiza <6900588+ArchiMoebius@users.noreply.github.com>
coolguy1771 referenced this pull request in coolguy1771/home-ops Nov 3, 2022
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker](https://togithub.com/docker/docker-py) ([changelog](https://docker-py.readthedocs.io/en/stable/change-log.html)) | patch | `6.0.0` -> `6.0.1` | --- ### Release Notes <details> <summary>docker/docker-py</summary> ### [`v6.0.1`](https://togithub.com/docker/docker-py/releases/tag/6.0.1) [Compare Source](https://togithub.com/docker/docker-py/compare/6.0.0...6.0.1) ##### 🐛 Bugfixes - Fix for `The pipe has been ended` errors on Windows ([#​3056](https://togithub.com/docker/docker-py/issues/3056)) - Support floats for timestamps in Docker logs (`since` / `until`) ([#​3031](https://togithub.com/docker/docker-py/issues/3031)) ##### What's Changed - docs: install package in ReadTheDocs build by [@​milas](https://togithub.com/milas) in [https://github.com/docker/docker-py/pull/3032](https://togithub.com/docker/docker-py/pull/3032) - Use latest stable syntax for Dockerfiles by [@​thaJeztah](https://togithub.com/thaJeztah) in [https://github.com/docker/docker-py/pull/3035](https://togithub.com/docker/docker-py/pull/3035) - feat: add support for floats to docker logs params since / until sinc… by [@​ArchiMoebius](https://togithub.com/ArchiMoebius) in [https://github.com/docker/docker-py/pull/3031](https://togithub.com/docker/docker-py/pull/3031) - Change prune test to use anonymous volumes by [@​cpuguy83](https://togithub.com/cpuguy83) in [https://github.com/docker/docker-py/pull/3051](https://togithub.com/docker/docker-py/pull/3051) - socket: handle npipe close by [@​nicks](https://togithub.com/nicks) in [https://github.com/docker/docker-py/pull/3056](https://togithub.com/docker/docker-py/pull/3056) ##### New Contributors - [@​ArchiMoebius](https://togithub.com/ArchiMoebius) made their first contribution in [https://github.com/docker/docker-py/pull/3031](https://togithub.com/docker/docker-py/pull/3031) - [@​nicks](https://togithub.com/nicks) made their first contribution in [https://github.com/docker/docker-py/pull/3056](https://togithub.com/docker/docker-py/pull/3056) **Full Changelog**: docker/docker-py@6.0.0...6.0.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMi4xIiwidXBkYXRlZEluVmVyIjoiMzQuMTIuMSJ9--> Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
feature to add support for floats to docker container logs method params
since / untildue to the fact that docker engine supports itRelated:
#1515
#2825