Skip to content

Conversation

blackxored
Copy link

Follow-up to #61 this PR disables bundle's root warning by default on default image, as well as slim and onbuild variants.
See rubygems/bundler#4113 for more details.

edit: fixes #61, fixes docker-library/rails#34

@yosifkit
Copy link
Member

The onbuild images won't need it since they'll get it FROM ruby; otherwise LGTM. 👍

@blackxored
Copy link
Author

Thanks for the answer! and sorry for the late response, had a crazy week. I've removed the instructions for the onbuild images.

@yosifkit
Copy link
Member

Not a problem, Thanks for the PR. 😄 LGTM

(change looks to have spaces instead of tabs, rather than round trip you again, I'll just update master after merge)

yosifkit added a commit that referenced this pull request Jan 25, 2016
…y-default Silence bundler's root warning by default
@yosifkit yosifkit merged commit 7266262 into docker-library:master Jan 25, 2016
tianon added a commit to infosiftr/stackbrew that referenced this pull request Jan 26, 2016
- `cassandra`: 3.2 (docker-library/cassandra#47) - `celery`: 3.1.20 - `mariadb`: resync entrypoint with MySQL (MariaDB/mariadb-docker#37, MariaDB/mariadb-docker#34) - `memcached`: fix SHA1 checking (docker-library/memcached#6) - `mongo`: 3.0.9, conditional chown, configdb (MariaDB/mariadb-docker#78) - `mysql`: fix init failure a bit (docker-library/mysql#134) - `percona`: resync entrypoint with MySQL (docker-library/percona#12) - `php`: update FPM to use `php-fpm.d` for config (docker-library/php#184) - `postgres`: remove EOL 9.0 (docker-library/postgres#122) - `python`: remove EOL 3.2 (docker-library/python#87) - `rabbitmq`: allow for `--user` to work (docker-library/rabbitmq#60) - `rails`: 4.2.5.1 - `redmine`: add SCMs (docker-library/redmine#9) - `rocket.chat`: 0.15.0 (RocketChat/Docker.Official.Image#13) - `ruby`: silence `root` warning (docker-library/ruby#63)
tianon added a commit to infosiftr/stackbrew that referenced this pull request Jan 26, 2016
- `cassandra`: 3.2 (docker-library/cassandra#47) - `celery`: 3.1.20 - `mariadb`: resync entrypoint with MySQL (MariaDB/mariadb-docker#37, MariaDB/mariadb-docker#34) - `memcached`: fix SHA1 checking (docker-library/memcached#6) - `mongo`: 3.0.9, conditional chown, configdb (MariaDB/mariadb-docker#78) - `mysql`: fix init failure a bit (docker-library/mysql#134) - `percona`: resync entrypoint with MySQL (docker-library/percona#12) - `php`: update FPM to use `php-fpm.d` for config (docker-library/php#184) - `postgres`: remove EOL 9.0 (docker-library/postgres#122) - `python`: remove EOL 3.2 (docker-library/python#87) - `rabbitmq`: allow for `--user` to work (docker-library/rabbitmq#60) - `rails`: 4.2.5.1 - `redmine`: add SCMs (docker-library/redmine#9) - `rocket.chat`: 0.15.0 (RocketChat/Docker.Official.Image#13) - `ruby`: silence `root` warning (docker-library/ruby#63)
tianon added a commit to infosiftr/stackbrew that referenced this pull request Jan 26, 2016
- `cassandra`: 3.2 (docker-library/cassandra#47), run as non-root and allow arbitrary `--user` (docker-library/cassandra#48) - `celery`: 3.1.20 - `mariadb`: resync entrypoint with MySQL (MariaDB/mariadb-docker#37, MariaDB/mariadb-docker#34) - `memcached`: fix SHA1 checking (docker-library/memcached#6) - `mongo`: 3.0.9, conditional chown, configdb (MariaDB/mariadb-docker#78) - `mysql`: fix init failure a bit (docker-library/mysql#134) - `percona`: resync entrypoint with MySQL (docker-library/percona#12) - `php`: update FPM to use `php-fpm.d` for config (docker-library/php#184) - `postgres`: remove EOL 9.0 (docker-library/postgres#122) - `python`: remove EOL 3.2 (docker-library/python#87) - `rabbitmq`: allow for arbitrary `--user` (docker-library/rabbitmq#60) - `rails`: 4.2.5.1 - `redmine`: add SCMs (docker-library/redmine#9) - `rocket.chat`: 0.15.0 (RocketChat/Docker.Official.Image#13) - `ruby`: silence `root` warning (docker-library/ruby#63)
RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
- `cassandra`: 3.2 (docker-library/cassandra#47), run as non-root and allow arbitrary `--user` (docker-library/cassandra#48) - `celery`: 3.1.20 - `mariadb`: resync entrypoint with MySQL (MariaDB/mariadb-docker#37, MariaDB/mariadb-docker#34) - `memcached`: fix SHA1 checking (docker-library/memcached#6) - `mongo`: 3.0.9, conditional chown, configdb (MariaDB/mariadb-docker#78) - `mysql`: fix init failure a bit (docker-library/mysql#134) - `percona`: resync entrypoint with MySQL (docker-library/percona#12) - `php`: update FPM to use `php-fpm.d` for config (docker-library/php#184) - `postgres`: remove EOL 9.0 (docker-library/postgres#122) - `python`: remove EOL 3.2 (docker-library/python#87) - `rabbitmq`: allow for arbitrary `--user` (docker-library/rabbitmq#60) - `rails`: 4.2.5.1 - `redmine`: add SCMs (docker-library/redmine#9) - `rocket.chat`: 0.15.0 (RocketChat/Docker.Official.Image#13) - `ruby`: silence `root` warning (docker-library/ruby#63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants