Prevent pg_ctl from timing out #109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This change is to prevent scenarios where a long-running database recovery would cause pg_ctl to time out, causing Docker to kill the container before it had a chance to recover.
| I'm not sure I fully understand what this change fixes -- database recovery wouldn't be happening in this block, right? (since this block is only for database initialization, so I'm confused how you'd be doing recovery during one of these |
| Ah, you're right. I have a wrapper entrypoint that my company is using internally which adds some functionality to the standard entrypoint. This internal entrypoint was running into these pg_ctl timeout issues. I fixed them in a number of places, including the standard docker-entrypoint.sh, but had forgotten that pg_ctl is not called by docker-entrypoint.sh after the database is initialized and therefore these changes are not necessary here. Sorry for the false alarm. |
| No worries, thanks for explaining! 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change is to prevent scenarios where a long-running database recovery would cause pg_ctl to time out, causing Docker to kill the container before it had a chance to recover.