Add newline to POSTGRES_PASSWORD file for initdb #1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tianon reviewed Dec 22, 2022
docker-library#1024 converted all `echo` calls to `printf`, but this change causes the password file used by `initdb` to be blank rather than contain a single newline. As a result, `initdb` will fail to start with an empty value with the error: ``` initdb: error: password file "/dev/fd/63" is empty ``` `POSTGRES_PASSWORD` can be blank if `POSTGRES_HOST_AUTH_METHOD=trust` is used. This change adds a newline to restore the original behavior. Closes docker-library#1025
stanhu force-pushed the sh-add-newlines-to-initdb branch from 1ffe3ab to 41bd7bf Compare 
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 22, 2022
Changes: - docker-library/postgres@ff5f92b: Merge pull request docker-library/postgres#1026 from stanhu/sh-add-newlines-to-initdb - docker-library/postgres@41bd7bf: Add newline to `POSTGRES_PASSWORD` file for initdb
| Thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#1024 converted all
echocalls toprintf, but this change causes the password file used byinitdbto be blank rather than contain a single newline. As a result,initdbwill fail to start with an empty value with the error:POSTGRES_PASSWORDcan be blank ifPOSTGRES_HOST_AUTH_METHOD=trustis used. This change adds a newline to restore the original behavior.Closes #1025