Fix pass callable object to sync_to_async #537
+24 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Maillol force-pushed the pass_callable_object_to_sync_to_async branch from 2ff7f84 to c440c61 Compare 
Member
| Good example @Maillol. This looks right. I'll try and pull a point release together shortly. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix: Prevent passing callable objects that overwrite context
This fixes a regression where passing a callable object like huey.Task would break the context attribute.
After this change, huey.Task and similar callables can be used without overwriting context, restoring previous behavior.