Skip to content

Conversation

@rvlb
Copy link
Contributor

@rvlb rvlb commented May 13, 2021

Closes #84
Closes #61
Closes #64
Closes #82

Testing:

npm install npm test 
@rvlb rvlb marked this pull request as ready for review May 13, 2021 17:03
@rvlb rvlb changed the title Update package Update package for 1.0.0 release May 13, 2021
@rvlb rvlb requested a review from fjsj May 13, 2021 17:09
"posttest": "tsc",
"test-watch": "jest --runInBand --env node --watchAll",
"travis": "yarn pretest && jest --runInBand --coverage --env node && codecov && yarn posttest"
"travis": "npm pretest && jest --runInBand --coverage --env node && npm posttest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was codecov not working here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, we should use coveralls instead due to recent security incidents.

Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvlb rvlb merged commit 6184f67 into master May 13, 2021
@fjsj fjsj deleted the update-package branch June 4, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants