Skip to content

Conversation

@rvlb
Copy link
Contributor

@rvlb rvlb commented May 13, 2021

Closes #80

This change makes the package behavior closer to what was on v0.4.3.

On 0.4.3, if we did this on webpack config file:

output: { path: path.resolve('./assets/bundles/'), filename: "[name]-[hash].js", chunkFilename: "[name]-[hash].js" }, plugins: [ new BundleTracker({filename: './webpack-stats.json'}), ],

The stats file is outputted at the same level of the config file (generally the frontend root).

The same configuration on 1.0.0-alpha.1 has th stats file is outputted as ./assets/bundles/webpack-stats.json, together with the other assets files. It's possible to manipulate the output by appending leading ../ to the filename or by using the path parameter in the BundleTracker configuration, however this can get rather confusing.

Tested on django-webpack/django-webpack-loader#271

@rvlb rvlb requested a review from fjsj May 13, 2021 12:35
Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvlb rvlb merged commit 07ee268 into master May 13, 2021
@fjsj fjsj deleted the output-tracker-file branch June 4, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants