Fix CI build #116
Merged
Fix CI build #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rvlb force-pushed the fix-ci-compatibility branch from 845a28d to 5f1ab68 Compare 
rvlb commented May 24, 2023
| "@types/lodash.defaults": "^4.2.6", | ||
| "@types/lodash.foreach": "^4.5.6", | ||
| "@types/babel__traverse": "7.0.6", | ||
| "@types/lodash": "4.14.173", |
There was a problem hiding this comment.
These 2 libs need to have their versions fixed, otherwise when running tsc post tests some node modules error start showing up if newer versions are used (these versions are installed as peer dependencies from other libs that have their versions set as "*").
fjsj approved these changes May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.