Fix corruption after hot updates due to misuse of lodash.merge #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
andersk added a commit to andersk/zulip that referenced this pull request Jul 6, 2021
django-webpack/webpack-bundle-tracker#101 Signed-off-by: Anders Kaseorg <anders@zulip.com>
timabbott pushed a commit to zulip/zulip that referenced this pull request Jul 6, 2021
django-webpack/webpack-bundle-tracker#101 Signed-off-by: Anders Kaseorg <anders@zulip.com>
| Thanks @andersk . |
| Added tests and fixed the TypeScript typings. (Why aren’t the CircleCI tests running on pull requests?) |
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
lodash.merge has the following undesired behavior on arrays: > chunks = { main: ['a', 'b', 'c', 'd', 'e'] } { main: [ 'a', 'b', 'c', 'd', 'e' ] } > merge(chunks, { main: ['foo', 'bar'] }) { main: [ 'foo', 'bar', 'c', 'd', 'e' ] } Instead of using lodash.merge, specify exactly which objects need to be combined using lodash.assign. Signed-off-by: Anders Kaseorg <andersk@mit.edu> 
fjsj approved these changes Jul 14, 2021
| Released at 1.2.0 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
lodash.mergehas the following undesired behavior on arrays:Instead of using
lodash.merge(#98), specify exactly which objects need to be combined usinglodash.assign.Cc @TomekStaszkiewicz @joaopslins