Skip to content

Add test for custom static url #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add test for custom static url #8

wants to merge 1 commit into from

Conversation

@pconerly
Copy link

@pconerly pconerly commented Aug 4, 2015

Just tossing this over for some transparency--- adding this test causes the test_jina2 test to fail in django1.6 and 1.7, with the error:

====================================================================== FAIL: test_jinja2 (app.tests.test_webpack.LoaderTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/peterconerly/code/django-webpack-loader/tests/app/tests/test_webpack.py", line 105, in test_jinja2 self.assertIn('<link type="text/css" href="/static/bundles/styles.css" rel="stylesheet">', result.rendered_content) AssertionError: '<link type="text/css" href="/static/bundles/styles.css" rel="stylesheet">' not found in u'<!DOCTYPE html>\n<html>\n <head>\n <meta charset="UTF-8">\n <title>Example</title>\n <link type="text/css" href="//:derp.com/_/static/bundles/styles.css" rel="stylesheet">\n </head>\n\n <body>\n <div id="react-app"></div>\n <script type="text/javascript" src="//:derp.com/_/static/bundles/main.js"></script>\n </body>\n</html>' ----------------------------------------------------------------------

The test_django_custom_static_url test sets STATIC_URL, but somehow it persists between tests.

Any ideas? It's stumping me.
@owais
Copy link
Collaborator

owais commented Aug 4, 2015

I can't help right now. Why don't you submit the PR. I'll try to fix the failing test case (jinja) tomorrow and then merge.

Thanks.
@pconerly
Copy link
Author

pconerly commented Aug 4, 2015

This is a PR :) Thanks!
@owais owais closed this Jan 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@pconerly @owais