Skip to content

Conversation

@fladi
Copy link
Contributor

@fladi fladi commented Feb 18, 2016

There is no need to hardcode the MANIFEST file as distutils/setuptools will
automatically create it from a MANIFEST.in template.

This also adds README.md to the shipped files as it is currently missing in the
tarball present on PyPI.

@fladi
Copy link
Contributor Author

fladi commented Feb 18, 2016

@luzfcb That's not really necessary. Those graft and global-exclude commands would only make sense if there was a greedy recursive-include dir * in there (e.g. for a docs/ folder structure).

@luzfcb
Copy link

luzfcb commented Feb 18, 2016

this was the standard that has been used in own django
https://github.com/django/django/blob/master/MANIFEST.in
introduced in django/django@93fc23b

I suppose if I do not include graft webpack_loader, the webpack_loader folder should not be included in the generated package ( not tested, I need to confirm this )

said that, as you are modifying the generation of the package, It would be good to include zip_safe=False, in setup.py, to force not install the package as an compressed .egg file, because django does not work well with packages in compressed .egg format

@fladi
Copy link
Contributor Author

fladi commented Feb 18, 2016

@luzfcb graft webpack_loader is not necessary, because that's the responsibility of setuptools when using the MANIFEST.in template to create the final MANIFEST file. All the packages listed by setup.py in packages = [...] are inserted into the final file. So there is no need for graft, it happens automatically.

zip_safe=False is only mandatory if your package tries to use any datafiles shipped with it during runtime. This is not the case for django-webpack-loader.

If you want a quick way to verify that my changes are correct, merge my branch and run python setup.py sdist; tar tfz dist/*.tar.gz to see the content of the source tarball that would be uploaded to PyPI.

@owais
Copy link
Collaborator

owais commented Feb 21, 2016

Looks good. Could you please rebase on latest master so we remove conflicts and we'll go ahead and merge this.

There is no need to hardcode the MANIFEST file as distutils/setuptools will automatically create it from a MANIFEST.in template. This also adds README.md to the shipped files as it is currently missing in the tarball present on PyPI.
@fladi
Copy link
Contributor Author

fladi commented Feb 25, 2016

@owais thanks, rebased my branch as requested.

owais added a commit that referenced this pull request Feb 25, 2016
Let MANIFEST be created from MANIFEST.in automatically.
@owais owais merged commit c38d41e into django-webpack:master Feb 25, 2016
@owais
Copy link
Collaborator

owais commented Feb 25, 2016

Thank you

@fladi fladi deleted the use_MANIFEST.in branch February 25, 2016 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants