Adding skip_common_chunks option to the get_files() template tag #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| bump |
fjsj reviewed Jan 9, 2024
| used_urls = getattr(request, '_webpack_loader_used_urls', None) | ||
| if not used_urls: | ||
| used_urls = request._webpack_loader_used_urls = set() | ||
| return [x for x in result if x['url'] not in used_urls] |
There was a problem hiding this comment.
Since there's more code here, we need to test this. Can you add tests that covers all conditions here?
fjsj reviewed Jan 9, 2024
| With all due respect, you are placing too much weight on the coverage. My code uses the same underlying functions that are already tested out. Feel free to add tests though, I just can't be bothered. |
| Covering |
fjsj approved these changes Jan 15, 2024
karolyi commented Jan 15, 2024
karolyi commented Jan 15, 2024
| Thanks for adding the tests. Could you please do a quick release so I can start using it? |
| 3.0.1 published. |
| Thanks. Can confirm it's working. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Season's greetings. :)
I need
get_files()to be able to useskip_common_chunksjust likerender_bundle()does, so I took a couple hours and implemented it.The goal here is to be able to render
<link rel="prefetch">(not preload) tags manually, skipping the ones from the chunk that are already downloaded viarender_bundle().Have this as my free contribution. :)