Derive exceptions from Exception. #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Per https://docs.python.org/3/library/exceptions.html: > programmers are encouraged to derive new exceptions from the Exception > class or one of its subclasses, and not from BaseException. Specifically deriving from BaseException prevents Jinja2 from handling errors and Django from displaying the debug page when the webpack build fails, because Jinja2 catches Exception (this is the logical behavior): https://github.com/mitsuhiko/jinja2/blob/5b498453b5898257b2287f14ef6c363799f1405a/jinja2/environment.py#L1009
owais added a commit that referenced this pull request Jan 24, 2016
Derive exceptions from Exception.
| Thanks |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Per https://docs.python.org/3/library/exceptions.html:
Specifically deriving from BaseException prevents Jinja2 from handling
errors and Django from displaying the debug page when the webpack build
fails, because Jinja2 catches Exception (this is the logical behavior):
https://github.com/mitsuhiko/jinja2/blob/5b498453b5898257b2287f14ef6c363799f1405a/jinja2/environment.py#L1009