Change BUNDLE_DIR_NAME to BUNDLES_URL #233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gilmrjc force-pushed the improve-bundle-dir-name-setting branch 2 times, most recently from 3002a3f to fbde189 Compare 
gilmrjc force-pushed the improve-bundle-dir-name-setting branch from fbde189 to 0b8daef Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The option BUNDLE_DIR_NAME indicates the path used as prefix for the webpack bundles. This is confusing because it is not a directory, it's a url prefix. Changing the name of this config make this explicit.
close: #207