Refs #2096: The theme selector now controls all colors #2116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Previously, if the system preference was dark mode and the user explicitly selected the light theme, the @media block still interferred with the styling. This is fixed by only evaluating the color scheme preference when initializing the toolbar and later only looking at our own selected theme. Also, removed the DEFAULT_THEME setting; falling back to system defaults seems much better to me.
matthiask force-pushed the theme-selector-fixup branch from 06dba2b to 7d76af6 Compare 
tim-schilling approved these changes Apr 2, 2025
| Yep, I think we should do a release soon-ish, especially since the release notes of 5.1 mentioned that we fixed the dark mode issue (but it has only been fixed for real with #2114 and this change). |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Previously, if the system preference was dark mode and the user explicitly selected the light theme, the @media block still interferred with the styling. This is fixed by only evaluating the color scheme preference when initializing the toolbar and later only looking at our own selected theme.
Also, this pull request drops the
DEFAULT_THEMEsetting, and instead prefers looking directly at the preferences of users' systems. Removing settings is most often a plus in my book. The main reason for removing it was to make the code easier to follow, because there's one less theme preference source to look at.Refs #2096
Checklist:
docs/changes.rst.