Skip to content

Conversation

jeffwidman
Copy link
Contributor

This code is no longer needed now that the GitHub dependency graph shipped support for pyproject.toml: https://github.com/orgs/community/discussions/6456#discussioncomment-5244057

I didn't include a changelog mention as this is not a user-facing change.

jeffwidman and others added 2 commits April 23, 2024 19:14
This code is no longer needed now that the GitHub dependency graph shipped support for `pyproject.toml`: https://github.com/orgs/community/discussions/6456#discussioncomment-5244057
@jeffwidman
Copy link
Contributor Author

Optionally, could simply nuke setup.py entirely, as most folks have moved to pip install, and those who haven't probably have a very specific reason/know how to handle the error that happens when they try it.

cc @ofek as I spotted this in your PR here: https://github.com/jazzband/django-debug-toolbar/pull/1690/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R18-R23

I was gratuitously plagiarizing from it to update some other OSS Python libs when I saw this bit of code... I know you've updated a ton of other repos, so just FYI.

@ofek
Copy link
Contributor

ofek commented Apr 24, 2024

Great to know, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants