Allow more control over tox Selenium tests #1897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Instead of unconditionally enabling Selenium tests for the py311-dj42-postgresql tox environment, enable them by default for that environment but allow them to be disabled if the user's DJANGO_SELENIUM_TESTS environment variable is empty. This will allow the user to run DJANGO_SELENIUM_TESTS= tox to run the full tox test suite with Selenium tests disabled.
matthiask approved these changes Mar 17, 2024
This was referenced Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #1892.
Instead of unconditionally enabling Selenium tests for the
py311-dj42-postgresqltox environment, enable them by default for that environment but allow them to be disabled if the user'sDJANGO_SELENIUM_TESTSenvironment variable is empty. This will allow the user to runto run the full tox test suite with Selenium tests disabled.
Checklist:
docs/changes.rst.