fix: Not all pages visible in page selector

[fsbraun]

Description

Fixes #238. Fixes #237.

Related resources

• Links to pages in another language can’t be added from the selection menu #237
• In django CMS 3 pages are offered twice in the link auto field #238

Checklist

• I have opened this pull request against master
• I have added or modified the tests when changing logic
• I have followed the conventional commits guidelines to add meaningful information into the changelog
• I have read the contribution guidelines and I have joined #workgroup-pr-review on
  Slack to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Improve page selector to show pages across all languages

Bug Fixes:

• Fix page selector to display pages from all available languages instead of just the current language

Enhancements:

• Modify page content query to include all languages in search results

[sourcery-ai]

Reviewer's Guide by Sourcery

The pull request modifies the page lookup functionality in the LinkSearchAutocomplete class to include all languages when searching for pages. This ensures that all pages are visible in the page selector, addressing issues where pages in different languages were not being displayed.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Modified the page lookup functionality in the LinkSearchAutocomplete class to include all languages when searching for pages.	Modified the get_queryset method to filter PageContent objects by all available languages instead of a single language. Added publisher_is_draft=True filter for django CMS versions 3.11 - 4.1.	djangocms_link/admin.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#238	Prevent duplicate pages from appearing in the link auto field in django CMS.	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.41%. Comparing base (86b1862) to head (8cf805f).
Report is 2 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@ ## master #240 +/- ## ========================================== + Coverage 95.39% 95.41% +0.02%  ========================================== Files 28 28 Lines 673 676 +3 Branches 86 87 +1 ========================================== + Hits 642 645 +3  Misses 14 14 Partials 17 17 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sourcery-ai]

Hey @fsbraun - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a comment explaining why publisher_is_draft=True is needed for older versions of django CMS.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}