Skip to content

Conversation

@n-rodriguez
Copy link
Collaborator

Thank you!

@SamSaffron
Copy link
Member

thanks this looks nice, happy to modernize here.

@SamSaffron
Copy link
Member

I am a bit concerned about moving bin -> exe move, is this a breaking change we need to document in README ?

@SamSaffron
Copy link
Member

@n-rodriguez would you like to help with some of the issue cleanup? happy to give you triage access here.

@n-rodriguez n-rodriguez force-pushed the wip/modernize_dependencies branch from a1ff25a to fd062a2 Compare August 6, 2025 08:14
@n-rodriguez
Copy link
Collaborator Author

n-rodriguez commented Aug 6, 2025

@SamSaffron

I am a bit concerned about moving bin -> exe move, is this a breaking change we need to document in README ?

I don't think this is a breaking change, bundler should handle this smoothly

Edit: actually I use this branch in my customer project :

 remote: https://github.com/n-rodriguez/prometheus_exporter.git prometheus_exporter (2.2.0) prometheus_exporter! prometheus_exporter (2.2.0)

and I also use a binstub in the project to launch prometheus_exporter (bin/prometheus_exporter) and everything is fine 😎

@SamSaffron
Copy link
Member

Thanks can you lint, then I will merge away, added you to the project with triage rights, you can now manage issues.

@n-rodriguez
Copy link
Collaborator Author

@SamSaffron

added you to the project with triage rights, you can now manage issues.

Thank you!

then I will merge away

I would prefer to merge #340 first.

@SamSaffron
Copy link
Member

Tgx is out at the moment and it needs a rebase, can you just add to your PR?

@SamSaffron SamSaffron merged commit 2c2613b into discourse:main Aug 8, 2025
15 checks passed
@n-rodriguez n-rodriguez deleted the wip/modernize_dependencies branch August 9, 2025 18:11
@n-rodriguez
Copy link
Collaborator Author

Tgx is out at the moment and it needs a rebase, can you just add to your PR?

@SamSaffron done! #349 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants