FEATURE: Add new metrics busy_threads from Puma #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Any chance of this being merged? |
Contributor
| @benoittgt This looks good to me. Can you add a changelog entry before I merge this? thank you! |
tgxworld approved these changes Apr 17, 2025
benoittgt force-pushed the add-requests_count branch from 01b19a3 to 255bf05 Compare 
Contributor Author
| @tgxworld thanks for the review. It should be good. ;) |
benoittgt force-pushed the add-requests_count branch from 255bf05 to 4193947 Compare 
Expose a prometheus metric new thread stats from Puma - puma/puma#3517
PrometheusExporterMiddlewareTest#test_redis_5_call_pipelined_patching: ArgumentError: wrong number of arguments (given 2, expected 3) test/test_helper.rb:12:in `call_pipelined' /Users/benoit.tigeot/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/redis-client-0.19.1/lib/redis_client.rb:412:in `block (2 levels) in pipelined' /Users/benoit.tigeot/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/redis-client-0.19.1/lib/redis_client/middlewares.rb:16:in `call' test/test_helper.rb:60:in `call_pipelined' lib/prometheus_exporter/instrumentation/method_profiler.rb:67:in `call_pipelined' /Users/benoit.tigeot/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/redis-client-0.19.1/lib/redis_client.rb:411:in `block in pipelined' /Users/benoit.tigeot/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/redis-client-0.19.1/lib/redis_client.rb:677:in `ensure_connected' /Users/benoit.tigeot/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/redis-client-0.19.1/lib/redis_client.rb:409:in `pipelined' /Users/benoit.tigeot/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/redis-client-0.19.1/lib/redis_client/pooled.rb:57:in `block in pipelined' /Users/benoit.tigeot/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/redis-client-0.19.1/lib/redis_client/pooled.rb:30:in `block in with' /Users/benoit.tigeot/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/connection_pool-2.4.1/lib/connection_pool.rb:110:in `block (2 levels) in with' /Users/benoit.tigeot/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/connection_pool-2.4.1/lib/connection_pool.rb:109:in `handle_interrupt' /Users/benoit.tigeot/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/connection_pool-2.4.1/lib/connection_pool.rb:109:in `block in with' /Users/benoit.tigeot/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/connection_pool-2.4.1/lib/connection_pool.rb:106:in `handle_interrupt' /Users/benoit.tigeot/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/connection_pool-2.4.1/lib/connection_pool.rb:106:in `with' /Users/benoit.tigeot/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/redis-client-0.19.1/lib/redis_client/pooled.rb:26:in `with' /Users/benoit.tigeot/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/redis-client-0.19.1/lib/redis_client/pooled.rb:57:in `pipelined' test/middleware_test.rb:118:in `test_redis_5_call_pipelined_patching'
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
benoittgt force-pushed the add-requests_count branch from 4193947 to 7125d8d Compare Contributor
| Sorry @benoittgt, can you fix the linting error before I merge. Thank you! |
Contributor Author
| Oups sorry. I've miss it @tgxworld. It should be good now. |
tgxworld reviewed Apr 21, 2025
tgxworld changed the title tgxworld approved these changes May 8, 2025
Contributor
| @benoittgt Sorry one last change before merging. The linting workflow is broken. |
Contributor Author
| No problem @tgxworld, I should have check. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
New Puma version has a nice addition of metric on busy threads.