Fix the build #330
Merged
Fix the build #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Broken by cbb669b
tgxworld commented Dec 5, 2024
| ::Dalli.stub_const(:Client) do | ||
| mock = Minitest::Mock.new | ||
| mock.expect :call, nil, [Dalli::Client, Array, :memcache, { instrument: :alias_method }] | ||
| mock.expect :call, nil, [Dalli::Client, Array, :memcache], instrument: :alias_method |
Contributor Author
There was a problem hiding this comment.
I don't 100% know my way around but if we reference the other lines this fixes the build
martin-brennan approved these changes Dec 5, 2024
martin-brennan left a comment
martin-brennan left a comment There was a problem hiding this comment.
Sometimes the ability to leave out parenthesis in ruby is really not helpful 😬
Contributor Author
| Thank you @martin-brennan 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Broken by cbb669b