FIX: Allow title to be blank when migrating custom_header_links #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This commit allows setting value of `Link Name, ,/some/path` to be migrated. This format of the setting was allowed and the current migration will not migrate the link if the title is empty which isn't what we want. Follows-up to 167bc8c
ZogStriP approved these changes Apr 26, 2024
| Thank you @ZogStriP 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This commit allows setting value of
Link Name, ,/some/pathto be migrated. This format of the setting was allowed and the current migration will not migrate the link if the title is empty which isn't what we want.Follows-up to 167bc8c