fix: dyld missing symbol called on arm arch #150
Merged
+16 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR addresses the
dyld: missing symbol calledfatal error on Apple Silicon by adding the required file for NEON compilation.The related issue, reported in #142, previously necessitated a workaround involving the use of x64 Node.js with Rosetta, resulting in degraded performance. This PR enables native support for the arm64 architecture in this library.
Additionally, I have added a test in
tests/test.js, which evaluates the Opus decoder's functionality.Before this PR is merged, users can use the source from this PR directly by modifying their package.json:
Semantic versioning classification: