Rename removeWildcardImports to forbidWildcardImports, etc. #2633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @iddeepak and @Pankraz76 - this okay with you? |
Open
| yes much more sound, thx. |
| Nice! LGTM. Let me know if you'd like another review when things are out of draft. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
removeWildcardImportsis a recent addition, and right now (and for the foreseeable future) it doesn't do what it says it does. It doesn't remove them, it just yells at you about it.In my own projects, I have actually ended up having quite a few rules that just yell "don't do this", and with our new "regex lint" thing, those can be a lot nicer with line numbers and easy suppression. So the point of this PR is to do a little refactor towards the "forbid" word.