Update Eclipse-based formatters to latest versions #2179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jochenberger force-pushed the update-groovy-eclipse branch 3 times, most recently from 0efbdd3 to afd3fb6 Compare 
Member
| Seems we can bump JDT and others as well, see #1939. |
jochenberger force-pushed the update-groovy-eclipse branch from afd3fb6 to 3895af5 Compare Contributor Author
Done |
jochenberger changed the title 
jochenberger commented Jun 20, 2024
| * Bump default `ktfmt` version to latest `0.49` -> `0.51`. ([#2172](https://github.com/diffplug/spotless/pull/2172)) | ||
| * Rename property `ktfmt` option `removeUnusedImport` -> `removeUnusedImports` to match `ktfmt`. ([#2172](https://github.com/diffplug/spotless/pull/2172)) | ||
| * Bump default `eclipse` version to latest `4.29` -> `4.32`. ([#2179](https://github.com/diffplug/spotless/pull/2179)) | ||
| * Bump default `greclipse` version to latest `4.49` -> `4.31`. ([#2179](https://github.com/diffplug/spotless/pull/2179)) |
Contributor Author
There was a problem hiding this comment.
We cannot update to 4.32 here yet, because, currently, the Groovy formatter version is tied to the Eclipse version and the matching plugin version has not been released yet (https://github.com/groovy/groovy-eclipse/milestone/25).
Goooler approved these changes Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.