Keep eclipseWtp step, remove the long-dormant _ext/eclipse-wtp project #1936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Note: this does not remove the
eclipseWtpstep, which is still available! It just removes the dormant_extfolder.Eclipse formatters were supported via the
_ext/eclipse-baseworkflow for a long time. It was labor intensive, and around 2 years ago they stopped getting updated. So we introduced a new workflow around the Equo runtime which has improved the situation somewhat.JDT, Groovy, and CDT were all converted in Mar 2023. The WTP conversion has a draft PR open which anyone can finish:
In the meantime, there's no reason for the day-to-day codebase to keep this complexity onboard.