Skip to content

Conversation

@loonatick-src
Copy link
Contributor

@loonatick-src loonatick-src commented Apr 23, 2025

This PR adds support for multiple Swift versions and separates the tests for macOS vs Linux.

  • The check.py script itself selects the appropriate Swift version -- if e.g. 6.1 ground truth is not present, then it will select the next lower version, i.e. 6.0.3 as of this PR. This handles the default case where the crasher's status has not changed.
  • A new macOS job has been added to the CI. I tried to make them one job, but it appears that that's not possible. E.g. a job with a macOS runner cannot have a container key. Conditionally setting container to null does not work.
  • An explicit # OK ground truth must be present, i.e. there is now one way to specify OK ground truths. Before this, no compiler output + no ground truth file implied OK as well.
@loonatick-src loonatick-src marked this pull request as draft April 23, 2025 18:09
@loonatick-src loonatick-src force-pushed the test/prep-for-multiple-swift-versions branch 2 times, most recently from ada1b19 to b4e99be Compare April 30, 2025 16:33
@loonatick-src loonatick-src force-pushed the test/prep-for-multiple-swift-versions branch 2 times, most recently from 2f57cab to 33bdda4 Compare May 2, 2025 15:33
@loonatick-src loonatick-src marked this pull request as ready for review May 2, 2025 15:54
@loonatick-src loonatick-src self-assigned this May 2, 2025
@loonatick-src loonatick-src force-pushed the test/prep-for-multiple-swift-versions branch from 1cc2aa9 to 33bdda4 Compare May 2, 2025 19:39
@loonatick-src loonatick-src force-pushed the test/prep-for-multiple-swift-versions branch from 33bdda4 to ec5a9c8 Compare May 2, 2025 20:37
@loonatick-src loonatick-src merged commit 3d865ea into main May 6, 2025
4 checks passed
@loonatick-src loonatick-src deleted the test/prep-for-multiple-swift-versions branch May 6, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants