Addressed some minor issues in the TDL implementation #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 5 commits October 22, 2025 15:46
…_apply are given as parameters. Previously no grid search was done in that case, which is unintuitive. Now a grid search is done using the given grid_search_over dict. (resolves dice-group#547)
…inal, used it in the feature construction of the TDL learner to exclude nominal containing expressions in the case that use_nominals is False. (fixes dice-group#548)
…earchCV class. Gives the user more freedom in setting up the GridSearch. For cv, which was manually set before the standart value is set to 10 s.t. previous behavior is preserved. (resolves dice-group#546)
… preserve previous behavior as much as possible, when it always included nominals.
Collaborator
| Thanks for the PR. |
Member
| Given
@alkidbaci we should filter/ignore OWLObjectHasValue if use_nominal is False. Thank you for the remark @alkidbaci |
Demirrr approved these changes Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adresses issues #546, #547, #548. Issues are addressed in seperate commits, so you can pick and choose what to include.