Skip to content

Conversation

Thomzoy
Copy link
Contributor

@Thomzoy Thomzoy commented Dec 2, 2022

See #93

@ochedru
Copy link
Collaborator

ochedru commented Dec 2, 2022

Thank you for your PR! Can you please rebase it? I had to revert to ubuntu-20.04 in the github actions to make the build work.

@Thomzoy
Copy link
Contributor Author

Thomzoy commented Dec 2, 2022

Thank you for your PR! Can you please rebase it? I had to revert to ubuntu-20.04 in the github actions to make the build work.

Done !

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Merging #94 (349a627) into master (9c1fcb7) will decrease coverage by 0.64%.
The diff coverage is 75.75%.

@@ Coverage Diff @@ ## master #94 +/- ## ========================================== - Coverage 84.05% 83.40% -0.65%  ========================================== Files 9 9 Lines 464 470 +6 Branches 90 93 +3 ========================================== + Hits 390 392 +2  - Misses 62 65 +3  - Partials 12 13 +1 
Impacted Files Coverage Δ
liccheck/command_line.py 75.29% <73.77%> (-0.01%) ⬇️
tests/test_check_package.py 100.00% <100.00%> (ø)
tests/test_get_packages_info.py 93.33% <0.00%> (-6.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Thomzoy
Copy link
Contributor Author

Thomzoy commented Dec 5, 2022

Well I should remove type hinting for compatibility with Python 2

@ochedru
Copy link
Collaborator

ochedru commented Dec 6, 2022

Well I should remove type hinting for compatibility with Python 2

Yup, and there is also an f-string. Maybe we'll drop support for Python 2 in the next major version.

@Thomzoy
Copy link
Contributor Author

Thomzoy commented Dec 6, 2022

Well I should remove type hinting for compatibility with Python 2

Yup, and there is also an f-string. Maybe we'll drop support for Python 2 in the next major version.

Ah yes my bad, I don't have Python 2 on my system so I cannot check it thoroughly

@ochedru
Copy link
Collaborator

ochedru commented Dec 6, 2022

The tests are ok. Could you please add an example of regex matching in the readme file, so users know how to use your feature? Thanks!

@Thomzoy
Copy link
Contributor Author

Thomzoy commented Dec 8, 2022

Done !

@ochedru ochedru merged commit f8b8caf into dhatim:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants