feat: Analyze licenses or-ed together separately #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The contribution instructions direct new code contributors to run test using `tox`. However, `tox` is not included in the `test-requirements.txt` file, requiring an extra step for new contributors to install `tox` manually. This commit adds `tox` to the `test-requirements.txt` file so that new code contributors automatically get it when they install the test requirements.
Multi-licensed packages may specify their allowed licenses using an `or` designation. This commit adds support for parsing out those `or`-ed licenses as if they had been listed separately.
Codecov Report
@@ Coverage Diff @@ ## master #100 +/- ## ========================================== + Coverage 84.25% 84.51% +0.26% ========================================== Files 9 9 Lines 470 478 +8 Branches 93 95 +2 ========================================== + Hits 396 404 +8 Misses 62 62 Partials 12 12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| Thank you for your PR! |
thehale added a commit to thehale/python-license-check that referenced this pull request May 5, 2023
This reverts commit 607d58e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Multi-licensed packages may specify their allowed licenses using an
ordesignation.
This commit adds support for parsing out those
or-ed licenses as if they hadbeen listed separately.
For example, the pypdfium2 project uses the valid SPDX license identifier of
Apache-2.0 OR BSD-3-Clause.