CI Integration #12
Merged
CI Integration #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
markdboyd suggested changes Nov 24, 2020
Contributor
markdboyd left a comment
markdboyd left a comment There was a problem hiding this comment.
Looks great! I have one very small requested change
| - name: Setup node.js 🏡 | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: '14.15.0' |
| @@ -0,0 +1,5 @@ | |||
| "use strict"; | |||
Member Author
There was a problem hiding this comment.
💥
We don't actually need to do this, however I find the imports and type-completion to be a bit simpler.
Comment on lines +28 to +32
| - name: Test 🧪 | ||
| run: | | ||
| npm test | ||
| | ||
| - name: Build 🏗️ |
Contributor
There was a problem hiding this comment.
We don't need to build before we test because we're testing against the TS directly?
Member Author
There was a problem hiding this comment.
Right, this PR adds a transform to Jest that allows Jest to do the translating on the fly.
Lines 28 to 31 in 0b21151
markdboyd approved these changes Nov 24, 2020
alukach added a commit that referenced this pull request Nov 24, 2020
* Update for gh-pages integration * Add GH Actions script * Test jekyll-action * Let jekyll-action build * Tmp rm target_branch * Up version * Update Gemfile.lock * Update PAT, set target branc * Only deploy on merges to main * Rm comments and persist-credentials option * Add cache * Add quores * Avoid collections for simplicity * Rm build command * Cleanup * Revert to docs path rather than construct dir * Add test step, use granular steps * Add emoji * Fix import? * Fix name * TS based testing * Add TS dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR:
main) deploys the Jekyll documentation to thegh-pagesbranch_config.yaml