Update for Swift 5.0 Support #430
Open
+137 −55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Remove unneeded entry of `Info.plist` from the `Copy Bundle Resources` build phase. - Apply Xcode suggested project settings updates. - Convert `SlideMenuControllerSwift` scheme to Swift 4.2. - Convert `SlideMenuControllerSwift-iOS` scheme to Swift 4.2. - Update `podspec` to increase version number to `4.2.0`. - Add `swift_version` to `podspec` (`4.2`). - Update `CHANGELOG.md` to indicate Swift 4.2 change.
Update for Swift 4.2 support
- Update `podspec` to set `version` to `5.0.0`. - Update `podspec` to set `swift_version` to `5.0`. - Update project targets to have `9.0` Deployment Target (this was already specified in `podspec`). - Update project with Xcode `10.2.1` recommended settings. - Refactor uses of `fabs(_:)` to `abs(_:)` to resolve warnings. - Convert `SlideMenuControllerSwift-iOS` target to Swift `5.0.0` via wizard (no changes required). - Add no-op `@unknown default:` handling for `handleLeftPanGesture(_:)` to resolve warnings. - Add no-op `@unknown default:` handling for `handleRightPanGesture(_:)`to resolve warnings. - Convert `SlideMenuControllerSwift` target to Swift `5.0.0` via wizard (no changes required). - Refactor usage of `.characters.count` to `.count` to resolve build error. - Refactor `substring(_:)` to use `.suffix` instead of removed `.substring` to build error.
Update for Swift 5.0.0 support
Update `CHANGELOG.md`
| Is possible to accept this pull request ? |
Open
| I made a fork with swift 5 support a while ago, seems they are not accepting any pull request. add this to your podfile |
| Is this merged to master already? |
Swift Package Manager Support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Update for Swift 5.0 Support
podspecto setversionto5.0.0.podspecto setswift_versionto5.0.9.0Deployment Target (this was already specified inpodspec).10.2.1recommended settings.fabs(_:)toabs(_:)to resolve warnings.SlideMenuControllerSwift-iOStarget to Swift 5.0.0 via wizard (no changes required).@unknown default:handling forhandleLeftPanGesture(_:)to resolve warnings.@unknown default:handling forhandleRightPanGesture(_:)to resolve warnings.SlideMenuControllerSwifttarget to Swift5.0.0via wizard (no changes required)..characters.countto.countto resolve build error.substring(_:)to use.suffixinstead of removed.substringto build error.CHANGELOG.mdto indicate Swift 5.0 change..swift-versionfile.Includes: Update for Swift 4.2 support
Info.plistfrom theCopy Bundle Resourcesbuild phase.SlideMenuControllerSwiftscheme to Swift 4.2.SlideMenuControllerSwift-iOSscheme to Swift 4.2.podspecto increase version number to4.2.0.swift_versiontopodspec(4.2).CHANGELOG.mdto indicate Swift 4.2 change.