use file basename by default #93
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The github API doesn't seem to like file names with a '/' in it, like you would get if you executed `gist /tmp/foo.txt` or `gist subdir/bar.c`. This yields a "422 Unprocessable Entity" error which can be very confusing. Using the file's basename eliminates this problem. This behavior can be disabled by passing `--no-basename` to gist.
| updated to 963a5f6 to avoid accidentally conflating a separate fix with the basename issue |
This was referenced May 5, 2012
| +1 |
| Just ran into this and the error is indeed very cryptic. A question regarding this patch – I'm probably missing something here – but what is the purpose of the |
| +1 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The github API doesn't seem to like file names with a '/' in it, like
you would get if you executed
gist /tmp/foo.txtorgist subdir/bar.c. This yields a "422 Unprocessable Entity" errorwhich can be very confusing. Using the file's basename eliminates this
problem. This behavior can be disabled by passing
--no-basenametogist.