Read from environment variable GITHUB_AUTH_TOKEN if set. #232
Conversation
| Hey @dylansm, are any other tools using this convention? |
| In terms of Github tools that use this particular variable name? None that I know of. But Rails, AWS gem and many more tools make use of environment variables as an alternative to writing to files that might inadvertently be committed to a repository, e.g. |
| Ok, my biggest concern is that this makes the code/interface more complicated, and I don't understand the user-benefit (it's not like people are likely to have this environment variable set, and so we can just "automatically work" for a large number of users). You need to have the token on disk somewhere (whether it's in Can you expand a bit on your actual use-case here? Otherwise I don't think it's worth the overhead |
| Having the choice to use an environment variable seems to me to be less invasive (for users) than creating a new dotfile. I prefer to keep my keys and secrets in a single file to spreading them all over my user directory. |
| ^ same. I keep secrets in one file for simplicity, and those secrets are generally environment variables. IMO, it really doesn't add that much overhead (technical or otherwise). |
| end | ||
| | ||
| def self.read_token_or_fetch_from_env | ||
| ENV['GITHUB_AUTH_TOKEN'] || self.read rescue nil |
There was a problem hiding this comment.
Variable name should be namespaced somehow to prevent conflicts. For instance, GIST_GITHUB_API_TOKEN or something.
This reverts commit 07a714b. I thought defunkt/gist#232 was merged, but that is not the case
| My use case is to load the token from the variable instead of the file, so I can use with Travis CI where I can encrypt the variable or pass it as a secret variable, otherwise, the file needs to be part of the repository, therefore visible for all. Another use case when used with Docker, it's safer to pass the key as the variable during the run, instead of keeping it as a file inside the container for other people to access. |
| One-liner to patch the installed Tested PR and it works as expected. Although a better variable as suggested would be nice. |
| Closing as too much time has passed, I'm still open to this change using |
5 participants
This prevents the need for another token file.