Chomp OAuth access token before use. #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
If a user is modifying the .gist file by hand there is a big risk that the user adds a newline to the file. That newline is causing gist to fail with "Error: Got Net::HTTPUnauthorized from gist:". So better remove the eventual newline with chomp before use. This is extra handy when setting up gist on an computer that you don't trust with your real GitHub credentials (pre-generated OAuth token).
ConradIrwin added a commit that referenced this pull request Sep 1, 2014
Chomp OAuth access token before use.
Collaborator
| Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If a user is modifying the .gist file by hand there is a big risk that the
user adds a newline to the file. That newline is causing gist to fail with
"Error: Got Net::HTTPUnauthorized from gist:".
So better remove the eventual newline with chomp before use.
This is extra handy when setting up gist on an computer that you don't trust
with your real GitHub credentials (pre-generated OAuth token).