Change package/server dependancy to local sql-parser #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
the21st approved these changes Jun 14, 2024
ondrejromancov deleted the orom/change-package-server-dependancy-to-local-sql-parser branch This was referenced Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
All the changes I made in #7 were in
packages/sql-parser. While running the publishing GitHub action we are buildingpackages/server, but it has a dependency on the published@joe-re/sql-parserand not the one I modified. ChatGPT advised me that thepackages/serverdependency could be changed to the localsql-parserso I modified using "@joe-re/sql-parser": "file:../sql-parser".If I'm proceeding correctly, what could be the next steps?
deepnote/sql-language-serverwith the same tagv1.7.2-deepnote. ChatGPT advised me that removing and pushing the same tag should overwrite it