Skip to content

Tweaks based on our requirements #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 22, 2023
Merged

Tweaks based on our requirements #2

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ab09472
Add a local testing schema and make sure it's loaded
the21st Mar 16, 2023
81f762e
Don't suggest automatic table aliasing insert text
the21st Mar 16, 2023
221a70b
Add suggestion for unscoped columns
the21st Mar 16, 2023
24bc072
Only suggest FROM clause tables after SELECT
the21st Mar 16, 2023
ec8d2d9
Suggest catalogs, database and tables one-by-one, hierarchically
the21st Mar 16, 2023
5648c4b
Update tests :nervouslaughter:
the21st Mar 16, 2023
a1b75cf
Remove unused import
the21st Mar 16, 2023
dffeea7
Stub logger to make the lib work in browser
the21st Mar 16, 2023
241b522
Improve the "not qualified" test
the21st Mar 21, 2023
1c3c5b3
Refactor allTableNameCombinations to getFullyQualifiedTableName
the21st Mar 21, 2023
2928b24
refactor createTableCandidates
the21st Mar 21, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't suggest automatic table aliasing insert text
  • Loading branch information
@the21st
the21st committed Mar 16, 2023
commit 81f762e6db22bf6d8df431e79d15f6904cf3103d
8 changes: 1 addition & 7 deletions packages/server/src/complete/Identifier.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,12 @@ export class Identifier {
const idx = this.lastToken.lastIndexOf('.')
const label = this.identifier.substring(idx + 1)
let kindName: string
let tableAlias = ''
if (this.kind === ICONS.TABLE) {
let tableName = label
const i = tableName.lastIndexOf('.')
if (i > 0) {
tableName = label.substring(i + 1)
}
tableAlias = this.onClause === 'FROM' ? makeTableAlias(tableName) : ''
kindName = 'table'
} else {
kindName = 'column'
Expand All @@ -66,11 +64,7 @@ export class Identifier {
}

if (this.kind === ICONS.TABLE) {
if (tableAlias) {
item.insertText = `${label} AS ${tableAlias}`
} else {
item.insertText = label
}
item.insertText = label
}
return item
}
Expand Down