Skip to content

Conversation

@doubleaxe
Copy link
Contributor

This PR should fix issue #58

I didn't have much time testing it, it works on my (complex) wsdl. Old tests pass, but I didn't write anything to test new functionality.

@dderevjanik
Copy link
Owner

Hi @doubleaxe

Thank you for the PR looks great, and I really appreciate your effort! 🎉
I tested it locally, and everything seems to work as expected.

To ensure the changes are complete and well-documented, could you please:

  • Add a unit test for the new functionality to help prevent future regressions
  • Update the documentation (new arguments) to reflect these changes
@doubleaxe
Copy link
Contributor Author

Hello @dderevjanik
I added small unit test, also fixed casing. I reverted second feature, option --stripNamespacePrefix which should strip this Tns prefix from generated names. I guess it is better to move it to separate PR - one PR one feature.

@dderevjanik
Copy link
Owner

@doubleaxe thank you very much! 🚀

@dderevjanik dderevjanik merged commit 98a9011 into dderevjanik:master Jan 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants