Fix broken imports from Fabric #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
cody-scott deleted the 581-importerror-cannot-import-name-get_pyodbc_attrs_before-from-dbtadaptersfabricfabric_connection_manager branch 
Contributor
| Do we need to update the dependencies of version 1.8.5 to be Fabric 1.8.8 and above? Right now its set to the 1.8 or above which caused an error when I updated to version 1.8.5 as it left my Fabric at 1.8.7 which lacks the exposed API this update is implementing. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
dbt-fabric has updated the method
get_pyodbc_attrs_beforetoget_pyodbc_attrs_before_credentialsand addedget_pyodbc_attrs_before_accesstokenin version 1.8.8.This updates for those new changes.